Closed aahnik closed 4 years ago
Once again thank you for your contribution.
But the new pull request is reducing the quality of Readme file. The main aim of the application to is to automate the WhatsApp web. Adding CSV will add more complications like every users might have their own file format like excel, even database technologies.
I do have an example demo software which uses this API and performs all the necessary functions which you have specified.
Have a look at this demo application which is made using Python: https://www.youtube.com/watch?v=kQgwyyOgp98
If you are interested I will make this example application as opensource.
I have also planned a few more features which I have to implement. Like I am planning to separate code from data e.g whatsapp generally updates its UI more frequently which results in changed XPATH and CSS Selectors thereby breaking the API.
Since this API has code and data together in a single class, the deployed application which uses this API is needed to be rebuilt. So I am planning to add XPATHS in seperate JSON file and import it via code.
Thank you and Regards, Visweswaran N
Thanks a lot for your review. I also thought of seperating all css/xpath selection outside the whatsapp.py file.
Yes, api breaks often as whatsapp changes its website structure.
I understand that many people may use database or excel
Google sheets, MS Excel, Libre Office, all have options to export CSV . CSV can also be generated from database using few lines of code.
I thought making a inbuilt function would benefit many people.
I think having an inbuilt batch sender can be beneficial.
thanks a ton 😊 Aahnik
Please consider the readme once again.
I think the conventions of codacy automatic code review is not apt always.
I am new to GitHub, I may not be aware of all best practises.
The codacy code review is unsatisfied with the hierarchy of headings and usage of bold inside headings.
But in my opinion, the readme file visually looks good
thanks a ton 😊 Aahnik
@VISWESWARAN1998
Have a look at this demo application which is made using Python: https://www.youtube.com/watch?v=kQgwyyOgp98
You had a public playlist called "LIFE" . The songs are great .
Many of the songs were already my favourites and in my playlist.
I would like to contact you personally @VISWESWARAN1998 . 🙂
Or please reply to my email
I have emailed you at your public email provided at GitHub
Thanks a ton 🙂 Aahnik
I have made changes solving #56 and #54 part 7 solved #48 in a modular approach for send_message, send_document,send_picture
I have made changes solving #56 and #54 part 7 solved #48 in a modular approach for send_message, send_document,send_picture,
By using a new method select_person()
here is a list of changes
read new readme
person
made the executable path of chrome driver dynamic