search

VITA-Group / FSGS

[ECCV 2024]"FSGS: Real-Time Few-Shot View Synthesis using Gaussian Splatting", Zehao Zhu*, Zhiwen Fan*, Yifan Jiang, Zhangyang Wang
Other
417 stars 34 forks source link

Reversed Depth from Midas #62

Closed penguinflys closed 2 months ago

penguinflys commented 2 months ago

https://github.com/VITA-Group/FSGS/blob/a536a64c5b366b1088be64eeadf9e791ca26897c/train.py#L121-L131

From above code, I see depth are transformed to the opposite number, but i guess that is not what reverse means, shouldn't it be 1/midas_depth_pseudo instead -midas_depth_pseudo?

Reference: https://github.com/isl-org/MiDaS/issues/261

Best Regards

penguinflys commented 2 months ago

As the papar only utilize relative depth, how to convert it to the depth seems not a big deal, i tried to use the 1/d way to produce real depth, but the rendering result gets worse. Perhaps hyperparameter should also be tuned.

more info can be found in #1

Anyways, it seems not to be a big deal.