search

VITA-Group / GLNet

[CVPR 2019, Oral] "Collaborative Global-Local Networks for Memory-Efficient Segmentation of Ultra-High Resolution Images" by Wuyang Chen*, Ziyu Jiang*, Zhangyang Wang, Kexin Cui, and Xiaoning Qian
MIT License
347 stars 76 forks source link

Minor bugs fixed and code improvement #9

Closed lamhoangtung closed 5 years ago

lamhoangtung commented 5 years ago

Hi. Thanks for you guys for the great works!

Lately I been trying to apply GLNet for real world problem using you guys code and having little bugs here and there. After a month trying to resolve a bunch of them, I finally mange to get GLNet working for my binary segmentation problem.

This PR contain some minor bugs fix and improvement while I working with you guys code.

If this PR don't meet the quality for a merge. It's totally fine but please told me what can I do to complete my contribution to this repo :D

Regards and thanks, Linus ;)

chenwydj commented 5 years ago

This pull request introduces 1 alert when merging 46ebe82c334bd7eba4b4efa9439f1d10388c80b2 into 867d2a644b88fc9131d250d589129211279fd0b7 - view on LGTM.com

new alerts:

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

chenwydj commented 5 years ago

This pull request fixes 5 alerts when merging c9d6b4dc28d0c9f61b737b43d9bb019bfe5e0374 into 867d2a644b88fc9131d250d589129211279fd0b7 - view on LGTM.com

fixed alerts:

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

chenwydj commented 5 years ago

Hi Hoàng Tùng Lâm! Thank you very much for your interest and great effort! I will review your commit and get back to you soon!

lamhoangtung commented 5 years ago

Thanks @chenwydj ;)

chenwydj commented 5 years ago

This pull request introduces 1 alert and fixes 5 when merging 0dc47fac116d760bda5e848fee44d69a133bce83 into 867d2a644b88fc9131d250d589129211279fd0b7 - view on LGTM.com

new alerts:

fixed alerts:

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

lamhoangtung commented 5 years ago

Since everything from training script and pertained model was uploaded by the author. I will close this PR :P