feat(ScreenSpinner): remove size prop from component

EldarMuhamethanov commented 1 month ago

close #7466

[x] Unit-тесты
[x] Документация фичи
[x] Release notes

Описание

Проп size в компоненте ScreenSpinner не нужен и работает неправильно, поэтому нужно от него избавиться
Также нужно добавить возможность прокинуть в компонент кастомную иконку

Изменения

Удалил проп size из компонента
Добавил проп customIcon и state: 'custom' для отображения кастомного компонента.

Release notes

BREAKING CHANGE

ScreenSpinner: удалено свойство size

<ScreenSpinner
 state="loading"
-  size="regular"
/>
<ScreenSpinner.Container>
- <ScreenSpinner.Loader size="small" />
+ <ScreenSpinner.Loader />
<ScreenSpinner.SwapIcon />
</ScreenSpinner.Container>

Улучшения

ScreenSpinner: добавлена возможность прокинуть иконку для state="custom" с помощью свойства customIcon

github-actions[bot] commented 1 month ago

size-limit report 📦

Path	Size
JS	385.39 KB (+0.05% 🔺)
JS (gzip)	116.53 KB (+0.04% 🔺)
JS (brotli)	95.69 KB (+0.06% 🔺)
JS import Div (tree shaking)	1.45 KB (0%)
CSS	330.84 KB (+0.02% 🔺)
CSS (gzip)	41.39 KB (+0.02% 🔺)
CSS (brotli)	32.86 KB (+0.02% 🔺)

codesandbox-ci[bot] commented 1 month ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

github-actions[bot] commented 1 month ago

e2e tests

Playwright Report

github-actions[bot] commented 1 month ago

👀 Docs deployed

✅ Styleguide
✅ Storybook

Commit 890836edfefb7de38e32006b5f0a36b9872ef7a7

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (aa5b849) to head (890836e). Report is 4 commits behind head on master.

Files with missing lines	Patch %	Lines
...components/ScreenSpinner/ScreenSpinnerSwapIcon.tsx	85.71%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #7523 +/- ## ========================================== - Coverage 95.21% 95.20% -0.01% ========================================== Files 384 384 Lines 11345 11348 +3 Branches 3720 3720 ========================================== + Hits 10802 10804 +2 - Misses 543 544 +1 ``` | [Flag](https://app.codecov.io/gh/VKCOM/VKUI/pull/7523/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VKCOM) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/VKCOM/VKUI/pull/7523/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VKCOM) | `95.20% <88.88%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VKCOM#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

inomdzhon commented 1 month ago

Конфликт(

EldarMuhamethanov commented 1 month ago

Конфликт(

Разрулил

vkcom-publisher commented 1 month ago

✅ v7.0.0-beta.0 🎉

VKCOM / VKUI