search

VKCOM / vk-api-schema

JSON Schema of VK API
MIT License
206 stars 63 forks source link

Wrong `account.getProfileInfo` response #223

Open elias506 opened 2 years ago

elias506 commented 2 years ago

account_user_settings object has json description:

"account_user_settings": {
      "type": "object",
      "allOf": [
        {
          "$ref": "objects.json#/definitions/users_user_min"
        },
        {
          "$ref": "objects.json#/definitions/users_user_settings_xtr"
        },
        {
          "properties": {
            "photo_200": {
              "type": "string",
              "format": "uri",
              "description": "URL of square photo of the user with 200 pixels in width"
            },
            "is_service_account": {
              "type": "boolean",
              "description": "flag about service account"
            }
          }
        }
      ],
      "additionalProperties": false
    },

and used in account_getProfileInfo_response response object:

"account_getProfileInfo_response": {
      "type": "object",
      "properties": {
        "response": {
          "$ref": "objects.json#/definitions/account_user_settings",
          "required": true
        }
      },
      "additionalProperties": false
    },

But users_user_min and users_user_settings_xtr objects have same last_name and first_name fields. Besides account.getProfileInfo method do not need users_user_min object in allOf

elias506 commented 2 years ago

fix by https://github.com/VKCOM/vk-api-schema/pull/214