search

VLSI-EDA / PoC

IP Core Library - Published and maintained by the Chair for VLSI Design, Diagnostics and Architecture, Faculty of Computer Science, Technische Universität Dresden, Germany
https://tu-dresden.de/ing/informatik/ti/vlsi
Other
538 stars 93 forks source link

Update __init__.py #53

Closed cjchin closed 6 years ago

Paebbels commented 6 years ago

Defaulting flags.Flags to the class provided by Python is not correct. The implementation provided by Python does not provide all needed capabilities.

Moreover, you need to provide a Pull Request description.

cjchin commented 6 years ago

Right, I was confused as to why Appveyor failed the CI process, and it was saying that flags module doesn't exist.

However 5 months ago, in Tom/MatrixSum's branch, almost the same code is able to pass the CI. So I still dont really understand. Do you know why?

I actually wanted to delete this pull request completely and didnt realize that the pull request still exists

Paebbels commented 6 years ago

In contrast to GitLab.com, you can not delete issues, PR, ... :).

cp .\tools\AppVeyor\config.private.ini .\py\
cp .\tools\AppVeyor\my_project.vhdl .\tb\common\
.\poc.ps1
py.exe : Traceback (most recent call last):
At line:1 char:1
+ py.exe -3 C:\projects\poc\py\PoC.py
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (Traceback (most recent call last)::String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

  File "C:\projects\poc\py\PoC.py", line 47, in <module>
    from Compiler                           import CompilerException, CompileSteps
  File "C:\projects\poc\py\Compiler\__init__.py", line 33, in <module>
    from flags                        import Flags
ModuleNotFoundError: No module named 'flags'

OK, yes ... it reports that flags is not found.
Source: line 50: https://ci.appveyor.com/project/Paebbels/poc/build/1.1.0-b121#L50

python -m pip install -r .\requirements.txt
Collecting colorama==0.3.7 (from -r .\requirements.txt (line 1))
  Downloading colorama-0.3.7-py2.py3-none-any.whl
Collecting py-flags==1.1.0 (from -r .\requirements.txt (line 2))
  Downloading py_flags-1.1.0-py3-none-any.whl

Here we see, py_flags was downloaded in version 1.1.0. It is currently available in version 1.1.2. We could increase the versions in the master requirements.txt file. See this report for the current version status: https://requires.io/github/VLSI-EDA/PoC/requirements/?branch=master