VLSIDA / OpenRAM

An open-source static random access memory (SRAM) compiler.
http://www.openram.org
BSD 3-Clause "New" or "Revised" License
809 stars 199 forks source link

sram attribute has no attribute 'control size' #127

Closed MaestroLiu3 closed 2 years ago

MaestroLiu3 commented 2 years ago

image I cannot seem to figure out the issue with the control size. I am currently trying to create 2 bank implementations but when I change the bank size to 2 and num_of_row = 1 to get the bank number I would get this error. The error is in compute_bus_sizes() module in the sram_base class in sram_base.py. I couldn't find self.control_size attribute either by going through the class hierarchy of the sram_base class, which itself inherits from desgin, verilog, and lef classes. self.control_size here I think is supposed to represent the number of control signals. Any help would be greatly appreciated.

mguthaus commented 2 years ago

Hi,

The two bank option has fallen out of date and is not supported right now. Your best bet is to create two SRAMs and combine their address space in Verilog.

Sorry, Matt

On Mon, Nov 29, 2021, 03:47 Jeffrey Liu @.***> wrote:

[image: image] https://user-images.githubusercontent.com/56708718/143862404-f05271a3-eccb-45c5-a352-8c3b0628829e.png I cannot seem to figure out the issue with the control size. I am currently trying to create 2 bank implementations but when I change the bank size to 2 and num_of_row = 1 to get the bank number I would get this error. The error is in compute_bus_sizes() module in the sram_base class in sram_base.py. I couldn't find self.control_size attribute either by going through the class hierarchy of the sram_base class, which itself inherits from desgin, verilog, and lef classes. self.control_size here I think is supposed to represent the number of control signals. Any help would be greatly appreciated.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/VLSIDA/OpenRAM/issues/127, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC67SL3PUZKAICKXDPMXAD3UONR45ANCNFSM5I65MQZA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

mguthaus commented 2 years ago

Also, the row size is a derived parameter and is not meant to be set manually. Users should typically only set the word size and number of words.

It seems that someone may have removed the code prohibiting 2 banks. We will need to add that back until we fix multi-bank.

mguthaus commented 2 years ago

We have removed a hard 2 bank option in liu of a "soft" two bank option.