search

VLSIDA / OpenRAM

An open-source static random access memory (SRAM) compiler.
http://www.openram.org
BSD 3-Clause "New" or "Revised" License
842 stars 204 forks source link

Missing whitespace between : and " on some attributes #256

Open TristanRobitaille opened 1 month ago

TristanRobitaille commented 1 month ago

Describe the bug Missing required whitespace between : and " in some groups. This is an example, notice the :" before min_pulse_width and minimum_period.

image

Version v1.2.48

To Reproduce Any valid configuration should lead to the same issue, but here's an example I used.

num_words = 32
tech_name = "scn4m_subm"
process_corners = ["TT"]
supply_voltages = [ 3.3 ]
temperatures = [25]
output_path = "temp"
output_name = "sram_32x8"
netlist_only = False

Expected behavior Per Liberty spec, a whitespace is required. https://media.c3d2.de/mgoblin_media/media_entries/659/Liberty_User_Guides_and_Reference_Manual_Suite_Version_2017.06.pdf

image

Additional context This bug leads to parsing failure on a parser like liberty-parser.

mguthaus commented 1 month ago

Can you submit a PR?

TristanRobitaille commented 3 weeks ago

Yes, just made one: https://github.com/VLSIDA/OpenRAM/pull/257