search

VLSLgithub / VL-theme-V1

0 stars 0 forks source link

There is a pixel in front of phone numbers placed by shortcode that needs to be removed #56

Open BigActual opened 5 years ago

BigActual commented 5 years ago

How can the issue be reproduced?

It is on each page

Link to the page in question:

vibrantlifecommunities.com

Screenshot of the problem:

image

What does your environment look like?

Win 10 Chrome 1080p

d4mation commented 5 years ago

This took me a second because I saw what you saw at first too. But this is not a pixel at all, actually. This is part of the underline for the link.

Any descenders in the typeface cut over the underline for links and in this particular font, it seems parenthesis have descenders. Since there's no other text in front of it inside the link, there's only a tiny sliver that shows on the left of the underline.

If you open the inspector and toggle the text-decoration: underline CSS Rule for the link you'll see it immediately go away.

This is a Chrome default styling that we could probably disable if you'd like, but overall I think it is a nice link style 🤐 It looks great everywhere else on the site.

https://superuser.com/questions/1293529/when-did-chrome-start-underlining-links-differently

BigActual commented 5 years ago

Let's see what is said about it. I understand now what you are describing. If this is an issue, let's talk about changing the standardized format of the phone number versus changing the chrome default. That seems to be more appropriate of an action.