search

VLprojects / webrtc-issue-detector

Diagnostic tool and troubleshooter for WebRTC applications with Mean Opinion Score (MOS) calculator
https://github.com/VLprojects/webrtc-issue-detector/
MIT License
87 stars 16 forks source link

Export BaseIssueDetector? #16

Closed MFarejowicz closed 7 months ago

MFarejowicz commented 7 months ago

Would love to make my own custom detectors that follow the format of the provided issue detectors. However, it looks like the library does not export the BaseIssueDetector that every detector extends.

Would it be possible to export this so that custom detectors can extend it and take advantage of the pre-defined class functions?

Thanks!

evgmel commented 7 months ago

Hi @MFarejowicz ! Of course, created the PR, will notify you here when the the release is built.

desher commented 7 months ago

@MFarejowicz thanks for pointing this out, missed it

MFarejowicz commented 7 months ago

Thanks for the quick response. The file actually already exported it, but I think we also want to add a line for it in here: https://github.com/VLprojects/webrtc-issue-detector/blob/master/src/detectors/index.ts, so that it'll get exported from the base index.ts?

evgmel commented 7 months ago

Yes) Because of the hurry missed that there's already export expression. Will make the changes soon in index.ts

evgmel commented 7 months ago

@MFarejowicz Done. Added export to https://github.com/VLprojects/webrtc-issue-detector/blob/master/src/detectors/index.ts#L1. You can use the latest 1.9.2 version to check it

evgmel commented 7 months ago

Resolved in this commit: https://github.com/VLprojects/webrtc-issue-detector/pull/18/commits/46ebb2dc72ad3ddc67dd212d119bf4f4eddd9afe

MFarejowicz commented 7 months ago

Thank you 🙏