crul fails parsing header

VLucet / rgovcan

Easy access to the Canadian Open Government Portal

https://vlucet.github.io/rgovcan/

21 stars 4 forks source link

crul fails parsing header #11

Closed KevCaz closed 3 years ago

KevCaz commented 3 years ago

Currently, we cannot load the package:

R> devtools::load_all()                                          
Loading ckanr
Error in xx[[2]] : subscript out of bounds

This is due to a bug in crul (see https://github.com/ropensci/crul/issues/150). We should wait and see!

VLucet commented 3 years ago

@KevCaz I am still getting the error even after installing the latest github version of crul. Am I doing something wrong or are you still getting the issue as well?

KevCaz commented 3 years ago

It's working here, we'll have to deal with warnings though...

VLucet commented 3 years ago

It's working for me as well - my tired monday evening brain mistakened the warnings for errors. We do need to deal with those. Any suggestions?

KevCaz commented 3 years ago

yep, we'll have to use suppressWarnings() cause otherwise we won't be able to test the package.... I'm working on a PR now.

KevCaz commented 3 years ago

sckott has suggested https://github.com/ropensci/conditionz, worth considering.

VLucet commented 3 years ago

This looks like a very useful package. Since your comment (and advice!) on the last PR, I would be warry of adding new dependencies unless it is really necessary. Let's stick to suppressWarnings(), if you agree.

KevCaz commented 3 years ago

Yep, let's do that for the time being!