search

VLucet / rgovcan

Easy access to the Canadian Open Government Portal
https://vlucet.github.io/rgovcan/
21 stars 4 forks source link

Build without warnings nor notes #7

Closed KevCaz closed 4 years ago

KevCaz commented 4 years ago

Hi @VLucet ,

I was looking at your package and was wondering whether it is an active project? I think it is a cool side project and if you want to keep working on it I might be able to give you a hand.

Anyway, as I was looking at your code I found some typos that I fixed and I also tweaked the documentation here and there so that it builds without any warning/note.

I also tweaked a bit the README.Rmd as you included some ?fun in code chunks and I thought it is easier without. Finally, I changed the output directory in the last code chunk as data is actually used for packages that include data, so I thought was better to change this!

Hope this could be useful!

VLucet commented 4 years ago

Hi @KevCaz thank you for this, it is very useful. This project has taken the back burner. It started with this ropensci/wishlist#27. I did some work and posted here https://discuss.ropensci.org/t/new-package-in-development-ropencan/1704. I then discussed some changes to the package here sckott/ckanr#113. At the time I tried my best but I think I was lacking some skills in R development, and then my thesis took most of my time. This PR acts as a good reminder that I could get back to work with this. I would love your help though. If you are interested, please read the issues I mentioned and let me know your thoughts!

VLucet commented 4 years ago

github is having lots of issues this morning. merging is not working yet