search

VMatrix1900 / draft-cats-metric-definition

Other
1 stars 3 forks source link

Unit of metrics in examples. #6

Open muzixing opened 6 days ago

muzixing commented 6 days ago

  1. Though it is example. We should specify one data unit/format instead of providing two formats, See below.

Integer or FP8, choose one. Also, we might not use GHZ as unit, may use MHZ? so that the format can be an integer?

Basic fields: Metric type: “compute type_CPU” Format: integer, FP8 Bits occupation: 4 octets Special fields: Frequency unit: GHZ Compute capabilities unit: FLOPs Source: Direct measurement Statistics: Mean

Same for Storage and Network, GB or GB/s seems a too big unit. Better to use a MB， MB/s to allow the data value as a integer instead of a FP8？ or we can choose GB, GB/s， and make the value as a float type.

  1. what is the score in the example of L1 Metric definition ? suggest to delete it. unless we have good reason to have it.
  2. same question to L2 metric, why do we have score?
VMatrix1900 commented 6 days ago
  1. I am fine with whatever units in the example.
  2. I think the score in the example means the value. Like value in TLV.
VMatrix1900 commented 4 days ago

Discussion 11.20: Only keep one format in example. Follow DMTF. What is the basic fields, special fields? Need to check consistency of all example in the draft.

muzixing commented 4 days ago

Score is the value of the metric. We do not need a score as a new K:V

VMatrix1900 commented 4 days ago

Discussion 11.20: add new field: unit.