search

VMormoris / tw2-stats

Apache License 2.0
3 stars 2 forks source link

Review All Table Column Names #3

Open djbears32 opened 2 years ago

djbears32 commented 2 years ago
  1. Capitalize all Column Headers
  2. Possible Rename?
VMormoris commented 2 years ago
  1. If you mean the first letter of each word. I would say that is probably a great idea. But I don't think capitalizing the whole word(s) of its column header would look that good.
  2. After reading your issue, I revisit the tables and watch more carefully at the column header(s). And I notice that some columns are named diffidently across tables. Having that in mind I believe that renaming some of the columns is essential for consistency's sake. Would you be kind enough to compile a list with the column header(s) that you want see renamed so we can discuss this further before we make any changes?
djbears32 commented 2 years ago

yea when i get to this ill put a list in here of what is it and what i suggest naming it to

ManourasM commented 2 years ago

I agree with Capitalizing at least the first letter in Column headers. Also some small mistakes to Header Names I found with a quick look:

  1. Spelling mistake in tribes table: victory points
  2. Inconsistent spaces on off bash and def bash Columns between tables
VMormoris commented 2 years ago

It took me a long time, but with the recent pull request #7 I manage to handle your request.

You can check out those and all the other changes I made at: dev.tw2-stats.com If you think that I should rename something else please don't hesitate to tell me.

djbears32 commented 2 years ago

Nice I'll take a look in a bit here and try and be a bit more focused on this stuff.