search

VMormoris / tw2-stats

Apache License 2.0
3 stars 2 forks source link

Review Setup Guide #8

Closed joaopedroo5 closed 1 month ago

joaopedroo5 commented 2 years ago

With the commit #6 I believe you allowed using the application for multiple world. With that you missed to update the Setup Guide in order to run file "database/tw2-stats_db_creation.sql"

P.s: This is my first issue, so take it with a bit of salt and help me improve 👍

-- Edit Added print screens of the problems that I believe where introduced with the commit. image

VMormoris commented 2 years ago

You are right when I merged the pull request #6 (World Overview), I forgot to update the Setup Guide. I will fix it but it might take a little while because right now I'm experimenting with docker which is suppose to make the setup process a lot easier (but it will require for me to rewrite the setup guide basically from scratch).

As far as the support for multiple worlds, the application was build from the start in a way that is suppose to support multiple worlds. But they are two big caveats at the moment:

Both of the issues that I described above, I'm planning to solve with the next update.

By the way since you are the first one that was trying the Setup Guide. Do you have any other idea about things that are missing or anything else that will make it better?

joaopedroo5 commented 2 years ago

I had no problems following the setup guide. It was simple and gave me clear instructions on what I was required to do.

Since you probably will take a while expediting the application to docker, maybe you could use the current issue to do a quick fix and keep the app running.

I've got to say, that I was happy to see someone interested on this, since is a fundamental toll many players, myself included use daily.

-- Edit I would recommend, since you're experimenting with docker you may add some way to check the state of database and connection with the tribal wars game.

VMormoris commented 2 years ago

I actually finish updating the app so it works using docker, I also update the Setup Guide on the wiki page. You can give it another try if you want to set it up, but the problems I mention earlier for multiple worlds should still exist.

Since I finished with docker I will start working on the next update, and as part of that I will be working on fixing the problems & adding more features. Depending on how much changes are need it I might be able to push the changes before the next update but don't get your hopes up.

In any case I will keep this issue open until they are resolve.