search

VNG-Realisatie / gemma-zds-client

2 stars 4 forks source link

Header parameter expects "required" even though its optional #24

Open SilviaAmAm opened 3 years ago

SilviaAmAm commented 3 years ago

Here it can be seen that the 'required' keyword is only required for path parameters: https://swagger.io/docs/specification/describing-parameters/ section "Required and Optional Parameters"

In the zds_client, the required keyword is also expected for header parameters: https://github.com/VNG-Realisatie/gemma-zds-client/blob/master/zds_client/schema.py#L100

JesseRoxit commented 2 years ago

Any reason why this PR has not been completed yet? We encounter the exact same issue, could this be completed?

sergei-maertens commented 2 years ago

We currently don't have any bandwidth to follow up on this :(

And it turns out that I don't have any rights anymore on this repository to maintain it :grimacing: