Closed joeribekker closed 5 years ago
Merging #112 into master will increase coverage by
8.37%
. The diff coverage is88.23%
.
@@ Coverage Diff @@
## master #112 +/- ##
==========================================
+ Coverage 38.2% 46.58% +8.37%
==========================================
Files 63 63
Lines 2209 2226 +17
Branches 328 332 +4
==========================================
+ Hits 844 1037 +193
+ Misses 1329 1133 -196
- Partials 36 56 +20
Impacted Files | Coverage Δ | |
---|---|---|
vng_api_common/generators.py | 90% <88.23%> (+56.66%) |
:arrow_up: |
vng_api_common/notifications/api/views.py | 73.52% <0%> (+2.94%) |
:arrow_up: |
vng_api_common/inspectors/polymorphic.py | 35.71% <0%> (+7.14%) |
:arrow_up: |
vng_api_common/inspectors/query.py | 38.46% <0%> (+7.69%) |
:arrow_up: |
vng_api_common/inspectors/cache.py | 100% <0%> (+20%) |
:arrow_up: |
vng_api_common/inspectors/fields.py | 54.54% <0%> (+20.45%) |
:arrow_up: |
vng_api_common/search.py | 54.54% <0%> (+22.72%) |
:arrow_up: |
vng_api_common/audittrails/viewsets.py | 38.46% <0%> (+38.46%) |
:arrow_up: |
vng_api_common/caching/introspection.py | 80% <0%> (+40%) |
:arrow_up: |
vng_api_common/inspectors/view.py | 72.37% <0%> (+45.3%) |
:arrow_up: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 34cebcc...1e9a832. Read the comment docs.
@joeribekker the impact on the _zoek
tag is a bit strange, no?
Klopt, dat is een actie op de ViewSet zaken
. Ik kan daar nog wel een uitzondering voor toevoegen, dat acties hun eigen "description" kunnen krijgen. Is dat denk je voldoende?
@joeribekker yeah, I think those should be pulled from the action method docstring, that's also how yasg works :thinking:
Impact op Zaken API:
Impact op Catalogi API: