The following messages are broadcasted when a submission is being graded:
grading-begin
test-case, one message for every test case
grading-end, includes information like time and memory usage.
Hence, these messages can be used to leak the number of test cases and time/memory usage even when testcase result visibility is set to "Show submission result only".
This PR fixes it by removing all additional information (they are not used at all) and not broadcasting test-case messages if testcase result visibility is not "Show all testcase result".
Note that this change applies to everyone because the event server does not have a notion of permissions. While superusers can view the full test case result, they no longer get live updates for each test case.
How Has This Been Tested?
Tested locally
Checklist
[x] I have explained the purpose of this PR.
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the README/documentation
[ ] Any dependent changes have been merged and published in downstream modules
[ ] Informed of breaking changes, testing and migrations (if applicable).
[ ] Attached screenshots (if applicable).
By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.
Description
Type of change: bug fix
What
The following messages are broadcasted when a submission is being graded:
grading-begin
test-case
, one message for every test casegrading-end
, includes information like time and memory usage.Hence, these messages can be used to leak the number of test cases and time/memory usage even when testcase result visibility is set to "Show submission result only".
This PR fixes it by removing all additional information (they are not used at all) and not broadcasting
test-case
messages if testcase result visibility is not "Show all testcase result".Note that this change applies to everyone because the event server does not have a notion of permissions. While superusers can view the full test case result, they no longer get live updates for each test case.
How Has This Been Tested?
Tested locally
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the AGPL-3.0 License.