VOLTTRON / volttron-pnnl-applications

New repository for PNNL developed VOLTTRON applications
BSD 3-Clause "New" or "Revised" License
10 stars 9 forks source link

Web App for ILC Config file generator #38

Open bbartling opened 2 years ago

bbartling commented 2 years ago

Is it possible to add more documentation to the ILC README and website to configure the ILC agent for how to get the Master Driver Configuration Store file?

I think the average slow to catch on types like maybe myself this is blatantly not obvious for how to get this file. At least I dont think there is anything I could find in the docs for VOLTTRON and no one else ever asked this on stackoverflow.

Thanks @rlutes for the stackoverflow answer, step one is checked off the list : )

craig8 commented 2 years ago

@bbartling would you be willing to create a PR with changes that have helped you in your usage? I think that would be awesome!

bbartling commented 2 years ago

Yes absolutely. Should I fork a copy of this repo?

craig8 commented 2 years ago

Yes! :)

bbartling commented 2 years ago

Working with @rlutes today here are some notes about issues we ran into on the web app to help generate ILC config.

  1. Make argument calculator inputs side by side not underneath between ALWAYS and NOT CURTAILED arguments:

image image

  1. Change name for AHU to AHU VAV or to VAV Box

image

  1. Make side bar of config "editable" for modify keys & values if needed on live web page:

image

  1. When using the COPY CENTER the MAX and MINs did not appear to copy correctly:

image

  1. In the MAIN CONFIGURATION there should be another key available:

"control_mode":"comfort" or "control_mode":"dollars" or image

Add in some logic to the web app we dont need min and max curtailment settings when set on comfort mode

  1. In the curtail setting keys there should be a min and max associated with offset. For example:
"curtail_setting":{
"point":"Space Temperature Setpoint BAS"
"load":800
"control_method":"offset"
"offset":2

I have to manually ADD in:

"min":
"max":
  1. Control Mode equation NOT WORKING, no calculator pops up to input a formula:

image

bbartling commented 2 years ago

Not sure if this is a big deal or not but the calculator seems to break point names down by space....im sure the config file generator works just fine but it looks funny if the BAS point names contain spaces, and then the calculator formula is modified after being saved it looks like this:

image

I had to modify point from BAS to local, so it looks like this: image

bbartling commented 2 years ago

Remove Javascript alert that appears to prevent the copying of one device config to multiple. I think I am getting an alert that only one config can be copied to another device....where in reality inside a building one config for a VAV box could be copied to 100's

image

bbartling commented 2 years ago

Some more items to add to the deficiencies that @rlutes and I noticed when using the web app to create the ILC config file:

  1. ISSUE on cluster

Typo : cluster needs to be replaced with clusters

  1. ISSUE on keys

In the config that states keys map_key and dict_name:

                        "room_type": {
                            "operation_type": "mapper",
                            "map_key": "zone_type",
                            "dict_name": "Lobby"
                        },

They are backwards, they need to be:

"dict_name": "zone_type"
"map_key": "Office"
  1. ISSUE on typo Typo: mapper needs to be mappers for example:
           "mappers": {
                "zone_type": {
                    "Private Office": 1,
                    "Office": 3,
                    "Conference Room": 1,
                    "Lobby": 9,
                    "RestRoom": 9
                }
            }
        }
    }
}
  1. ISSUE on incorrect key name

More typos in the control config device status keywords incorrect operation change to condition for example:

"operation_args": [
device_status_args[
bbartling commented 2 years ago

On the web app for directions to help make the config file remove any params that are no longer used on the ILC algorithm, its too confusing for newbies.....

(verify with @rlutes which ones are longer used) image

rlutes commented 2 years ago

In the main ILC configuration config, the parameter curtailment_confirm should be changed to confirm_time. Also, curtailment_break is no longer used in the code, remove from configuration.

kevinatkinson-pnnl commented 2 years ago

Remove Javascript alert that appears to prevent the copying of one device config to multiple. I think I am getting an alert that only one config can be copied to another device....where in reality inside a building one config for a VAV box could be copied to 100's

image

@bbartling - Replying to this, is the intent to copy device topic info from one device to multiple? This can be done by performing the copy on all devices wanting to have the values from another device. Please let me know what's desired here. Not exactly sure what you're trying to do.