Forwarder's historian setup does not raise gevent.Timeout

VOLTTRON / volttron

VOLTTRON Distributed Control System Platform

https://volttron.readthedocs.io/

Other

455 stars 216 forks source link

Forwarder's historian setup does not raise gevent.Timeout #1018

Closed ghost closed 7 years ago

ghost commented 7 years ago

The event.wait(timeout=10) will block for up to ten seconds and return false if the event is not set.

ghost commented 7 years ago

Other instances of this pattern that should be looked at:

[x] examples/Alerter/send.py
[x] volttrontesting/utils/platformwrapper.py
[x] volttron/platform/vip/agent/core.py (used correctly)
[x] volttron/platform/vip/agent/connection.py
[x] volttron/platform/vip/agent/utils.py

new issue for 4.1 is #1107

craig8 commented 7 years ago

@mikeroup do you mind if I make the changes to some of these? I think most of them actually were my code!

craig8 commented 7 years ago

@mikeroup See #1020 for coments on how we need to revamp the ForwardHistorian. However for the 4.0.1 release lets just do the minimal and use the utility functions for creating agents or connections to the external platform.