Possible Improvements for VC and Platform Agent

Platform Agent

[x] O(N^2) logging of devices in _on_device_message()
[ ] a try/except block could be more clear than checking to see if a defaultdict defaulted in _on_device_message()
[ ] self._topic_replace_list could be better represented as a {x: y} dictionary instead of a list of {'from': x, 'to': y} dictionaries.
[ ] is_ip_private() and find_registration_address() are never used
[x] Black hole for settings if the agent is restarted: _load_settings() is never called
[x] is_managed() raises an exception because self._vc doesn't exist
[x] update_sibling_address_cache() is never called / not exported
[x] publish_to_peers() tries to access an attribute that doesn't exist
[x] register_service() does nothing
[ ] on_heartbeat_topic() does nothing but log
[ ] list_agent_methods() does nothing

Volttron Central

[ ] ABCMeta is used for class Connected but not the related decorators
[ ] _on_platform_heartbeat does nothing but log
[ ] _auto_register_peer() does nothing
[ ] get_platforms() and list_platform_details() are the same function
[ ] _disconnect_peer_platform() is never called / not exported
[ ] _get_agents() is never called / not exported
[ ] _store_registry() and _to_jsonrpc_obj() are only called once and consist of a single line of code
[ ] The provisional keyword arg is never used in _register_instance()

[ ] The advanced register platform window tries to call unknown method register_platform

VOLTTRON / volttron