Open ghost opened 8 years ago
Platform Agent
O(N^2)
_on_device_message()
self._topic_replace_list
{x: y}
{'from': x, 'to': y}
is_ip_private()
find_registration_address()
_load_settings()
is_managed()
self._vc
update_sibling_address_cache()
publish_to_peers()
register_service()
on_heartbeat_topic()
list_agent_methods()
Volttron Central
ABCMeta
class Connected
_on_platform_heartbeat
_auto_register_peer()
get_platforms()
list_platform_details()
_disconnect_peer_platform()
_get_agents()
_store_registry()
_to_jsonrpc_obj()
provisional
_register_instance()
UI
register_platform
@craig8 review
Platform Agent
O(N^2)
logging of devices in_on_device_message()
_on_device_message()
self._topic_replace_list
could be better represented as a{x: y}
dictionary instead of a list of{'from': x, 'to': y}
dictionaries.is_ip_private()
andfind_registration_address()
are never used_load_settings()
is never calledis_managed()
raises an exception becauseself._vc
doesn't existupdate_sibling_address_cache()
is never called / not exportedpublish_to_peers()
tries to access an attribute that doesn't existregister_service()
does nothingon_heartbeat_topic()
does nothing but loglist_agent_methods()
does nothingVolttron Central
ABCMeta
is used forclass Connected
but not the related decorators_on_platform_heartbeat
does nothing but log_auto_register_peer()
does nothingget_platforms()
andlist_platform_details()
are the same function_disconnect_peer_platform()
is never called / not exported_get_agents()
is never called / not exported_store_registry()
and_to_jsonrpc_obj()
are only called once and consist of a single line of codeprovisional
keyword arg is never used in_register_instance()
UI
register_platform