VORPCORE / vorp_character-lua

character creation for RedM Vorp core framework
GNU General Public License v2.0
9 stars 47 forks source link

Essential Changes #37

Closed AnishBplayz closed 11 months ago

AnishBplayz commented 11 months ago

This PR is entirely dedicated to optimizing the script's functionality, and I have thoroughly tested it to ensure its effectiveness.

Changes -

outsider31000 commented 11 months ago

image what is this for ?this is not needed in fact i see you add this to vorp core , its not needed and will be removed. heres why image no need to set it twice

image this is also not needed it will always exist no need for redundante checks

image remove these [''] symbols they exist to add an index with special characters and spaces in which is not this case.

image

in here you need to add an error check , other wise it will always say the names are listed as banned so maybe for banned to nil and for name missing to false and change it where the function call it image for example

the stop loop variable needs to stay if players press to delete their character (and dont delete) and select spawn it will close the loop , other wise the message stays in screen and its not removed because they ddint delete it. please add it back.

once these are done ill merge it thank you.

outsider31000 commented 11 months ago

the rest seems to be fine for me

AnishBplayz commented 11 months ago

@outsider31000 Please review the PR now!