search

VORPCORE / vorp_weaponsv2

vorp_weaponsv2 aka syn weapons
8 stars 31 forks source link

Fix Throwable weapons bug #42

Closed EnerGonix closed 2 months ago

EnerGonix commented 2 months ago

Fixed a bug were the throwable weapons were unusable

Pull request template

[!IMPORTANT] Please complete all fields. PRs will not be merged if any fields are incomplete. Be respectful, and keep in mind that it may take some time for your PR to be reviewed.

Bear in mind refactors are up to the developers and not it's contributors after all we are the ones giving support when needed. if they are big changes I suggest you to release it under your name instead.

Type of change

Motive for This Pull Request

explanation field

Provide a brief explanation of why these changes are being proposed and what they aim to achieve.

explanation field

Explain the necessity of these changes and how they will impact the framework or its users.

explanation field

Please describe the tests you have conducted to verify your changes. Provide instructions so we can reproduce these tests. Also, list any relevant details for your test configuration.

Notes if any

explanation field

EnerGonix commented 2 months ago

Fixed a bug were the throwable weapons where unusable. Now its fixed

outsider31000 commented 2 months ago

why do we have a templafe for pull requests if you dont use it? also can you explain what issue you had ? i just used a WEAPON_MELEE_HATCHET and i can throw it no problem

your pull request is messing with ammo, while throwables are weapons?

outsider31000 commented 2 months ago

the issues isnt fixed by removing the check, the operator <= its whats wrong. I will close this and adjust it.

EnerGonix commented 2 months ago

The axe works but example the bollas does not

Enviado de Outlook para Androidhttps://aka.ms/AAb9ysg

From: Outsider @.> Sent: Sunday, September 29, 2024 5:04:38 PM To: VORPCORE/vorp_weaponsv2 @.> Cc: En3rGonix @.>; Author @.> Subject: Re: [VORPCORE/vorp_weaponsv2] Fix Throwable weapons bug (PR #42)

Closed #42https://github.com/VORPCORE/vorp_weaponsv2/pull/42.

— Reply to this email directly, view it on GitHubhttps://github.com/VORPCORE/vorp_weaponsv2/pull/42#event-14445640534, or unsubscribehttps://github.com/notifications/unsubscribe-auth/APFZRTX3NV5LG27BSYPABEDZZAQJNAVCNFSM6AAAAABPBXATZOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGQ2DKNRUGA2TGNA. You are receiving this because you authored the thread.Message ID: @.***>

outsider31000 commented 2 months ago

yes because its a non ammo weapon, either way I have fixed it the operator was wrong. thanks