search

VPenkov / okayNav

The world's okayest responsive navigation. This is (sort of) a legacy implementation. Please stay tuned to the 3.0 branch (https://github.com/VPenkov/okayNav/tree/v3.0)
4.02k stars 266 forks source link

Menu gets buggy when maximizing #13

Closed abeninskibede closed 8 years ago

abeninskibede commented 8 years ago

Hey the plugin looks great, but there are some issues when maximizing the window and restore it back to original width and height.

http://screencast.com/t/WVg42FNO

VPenkov commented 8 years ago

This doesn't seem to occur in "normal" usage. I'll investigate the issue.

fergyfresh commented 8 years ago

Maybe we don't have the proper header attributes? My nav is embedded in the header and I don't use the same flexbox stuff you use in the header and mine acts wonky. https://github.com/fergyfresh/carpool/tree/okayNav

VPenkov commented 8 years ago

There might be issues when not using flexbox. Should be taken care of in the next version. It seems that I was trying to do too much in a short timespan.

fergyfresh commented 8 years ago

@abeninskibede I will update this post if I have a workaround.

VPenkov commented 8 years ago

Fixed in the current version. Nav will now work with floats as well.

curtiswilkinson commented 8 years ago

Awesome plugin. I've been attempting implement this to a testing navigation, and even after the recent commit for this issue I seem to be having the same problems as above. It still doesn't seem to be re-revealing menu options after they are hidden on window resizing for my implementation. untitled screencast

VPenkov commented 8 years ago

Can I get a link to this? Try wrapping the nav in a <div id="nav-main-wrapper"> and initialize it like this:

$('#nav-main').okayNav({
    parent: '#nav-main-wrapper'
});
curtiswilkinson commented 8 years ago

I gave that a try with no luck, here is the link to the generic prototype of this: http://curtis.neto.com.au/

There has been some CSS changes obviously but the JS implemented is identical to the release for this issue.

Thanks for taking a look