search

VPenkov / okayNav

The world's okayest responsive navigation. This is (sort of) a legacy implementation. Please stay tuned to the 3.0 branch (https://github.com/VPenkov/okayNav/tree/v3.0)
4.02k stars 266 forks source link

Global _options variable avoids using multi okayNav instance in one page #34

Open pmoradei opened 8 years ago

pmoradei commented 8 years ago

Hi, very nice plugin!

My problem : _options variable is declared globally and can cause problems if I use several okayNav instances in one page. Do you think it could become a instance property?

Same problem for the $navigation,$nav_visible,$nav_invisible variables. Do you think they could also become instance properties?

VPenkov commented 8 years ago

Currently it's not possible to use okayNav in multiple instances for a variety of reasons. At least, not out of the box anyway. But yeah, point taken, leaving this open for now.

pmoradei commented 8 years ago

Ok, thanks