search

VPenkov / okayNav

The world's okayest responsive navigation. This is (sort of) a legacy implementation. Please stay tuned to the 3.0 branch (https://github.com/VPenkov/okayNav/tree/v3.0)
4.02k stars 267 forks source link

Remove jQuery dependency #5

Open mrmartineau opened 8 years ago

mrmartineau commented 8 years ago

Having this as a jQuery plugin is extremely useful to those that use jQuery, but as I don't ever use jQuery, I would never use this plugin. Now, if you were to create it using native js you would be able to allow use for jQuery and non-jQuery users alike. @desandro does a great job of this in some of his modules, like Flickity for example: http://flickity.metafizzy.co/#initialize-with-jquery

VPenkov commented 8 years ago

It is an interesting suggestion but I don't think I will be doing that in the immediate future. What I wanted to create was a jQuery plugin with a simple API.

Besides, jQuery is getting better and faster and I am very excited to see if 3.0 will bring the speed boost everyone's hoping for.

I'll ensure compatibility with other libraries like Zepto if I see the demand to do so but currently there are core features on the roadmap that aren't yet finished so those are a priority.

For example, I am working on app-style realtime swipe actions because this will be a pretty cool thing to see on the web. This was actually the idea that gave birth to okayNav.

So there's a chance that I'll focus on a vanilla JS implementation but I don't reckon this will happen in the next month or two. Until then, we can only hope for a generous pull request.

Keep an eye on the roadmap for more details (more like less details).

mrmartineau commented 8 years ago

Okay.. those are good reasons. Perhaps I'll fork it and make a non-jQuery version with the same feature set..

VPenkov commented 8 years ago

I suggest to hold on until the swipe thingy is done. It should make a few things obsolete and change others.

karlprieb commented 8 years ago

I'll use this in my current project, but I'll work on a dependecy-free fork. Can I do PR after I finish?

VPenkov commented 8 years ago

@karlprieb you should join our Gitter. We're working together with @jonathantneal on this.

ttbarnes commented 8 years ago

Will look forward to seeing dependency-free version. With vanilla JS it could be wrapped for use with for example Angular, React.

VPenkov commented 8 years ago

It's already almost available; keep an eye on this repo for a beta.