VR-25 / acc

Advanced Charging Controller
https://github.com/Magisk-Modules-Repo/acc
GNU General Public License v3.0
1.71k stars 107 forks source link

[Bug][acc pause_capacity resume_capacity] does not respect enforced charging switch #213

Closed Mark-Joy closed 9 months ago

Mark-Joy commented 11 months ago

Version: Latest release acc_v2023.8.19_202308190 Steps to reproduce: 1> Set resume_capacity < current capacity < pause_capacity for device to charge normally Example: 65% < current capacity 70%, < 90%

λ [~] $ sudo cat /data/adb/vr25/acc-data/config.txt | grep capacity=
capacity=(5 50 65 90 auto false)

2> Enforce working switch: sudo acc -ss

λ [~] $ sudo cat /data/adb/vr25/acc-data/config.txt | grep chargingSwitch
chargingSwitch=(battery/input_suspend 0 1 --)

3> Now, set resume_capacity < pause_capacity < current capacity for device to stop charging:

Expected behavior: Device stop charging using enforced charging switch Real behavior: Device stop charging using other charging switch

λ [~] $ sudo acc 65 50
λ [~] $ sudo cat /data/adb/vr25/acc-data/logs/write.log
───────┬────────────────────────────────────────────────────
       │ File: /data/adb/vr25/acc-data/logs/write.log
───────┼────────────────────────────────────────────────────
   1   │ /proc/mtk_battery_cmd/current_cmd
───────┴────────────────────────────────────────────────────

https://github.com/VR-25/acc/assets/22109528/ebbcd969-47c7-4d3c-abba-62acbdf42fe0