search

VR-25 / acc

Advanced Charging Controller
https://github.com/Magisk-Modules-Repo/acc
GNU General Public License v3.0
1.74k stars 109 forks source link

Acc disable in magisk continue starting #90

Closed remdu92 closed 3 years ago

remdu92 commented 3 years ago

Hi guys,

I've installed acc magisk module and acca app to manage it. I have disabled the acc module in magisk but it's still starting. I've found with htop that the deamon start with init.d second stage.

After 1hour of research, I can't find where the boot flag is setup ... Module is disabled so I can not see it in magisk log.

Does someone know why it keep starting ? Related to acca app ?

Thanks in advance.

Ps : last magisk and acc module on a galaxy s20 4g

bege10 commented 3 years ago

Same issue on Fairphone 3, /e/OS (based on FairphoneOS, LineageOS for microG, Android 10), Magisk 23001, ACC 2021.2.25, AccA 1.0.29.

VR-25 commented 3 years ago

AccA does not honor Magisk's module disable flag. Thus, the app is launching accd on boot_completed. I'll make acc daemon quit if that flag is set. Thanks.

Rihcus commented 3 years ago

Not sure if this belongs here, does uninstalling acc via magisk instead of from say termux or shell fully remove acc and any modifications. Additionally does acc modify any partitions outside of boot.img of the source rom (ie If I where to reinstall lineage os would modifications from acc still persist).

VR-25 commented 3 years ago

Yes, uninstalling acc via magisk fully removes it too. Magisk executes acc's uninstall.sh (cleanup script) upon uninstall. ACC is always systemless - meaning, it never touches any other partition besides data. Modifications made by acc to control charging don't survive a reboot/shutdown, just like any kernel tweak.

VR-25 commented 3 years ago

The upcoming release has this fixed.