Multiple additions to Practice Mode (1 Player) + 9 Ball table colors and more

VRCBilliards / vrcbce

VRCBilliards: Community Edition

MIT License

307 stars 37 forks source link

Multiple additions to Practice Mode (1 Player) + 9 Ball table colors and more #128

Closed Codel1417 closed 2 years ago

Codel1417 commented 3 years ago

Added

Shot Undo / Redo System
Shot Preview System
Shot Physics Replay
9 Ball affects table lights
More accurate Simulation option (off by default)

Removed

Bit Shifting
uints
Redundant Variables

Fixed

Cue ball spinning in pocket #121

Plans for future PR

Store / Load ball positions. to allow storing state for practice. (Can be added later)
Ability to move all balls manually

To do before this is ready for release

Network Testing
Esnya UI setup. (Only tested and set up in moon ui)
~Metal and fox table setup~ Should just work

FairlySadPanda commented 2 years ago

Yup, Floof has a tonne to do getting their work up-to-date but they've gotten started.

FairlySadPanda commented 2 years ago

@Codel1417 - please either fix this PR or close it within the next week.

Legoman99573 commented 2 years ago

Probably could fork it and compare changes to master and adjust accordingly if needed. Would require alot of testing to make sure everything works correctly.

Codel1417 commented 2 years ago

Going to close for now. I plan to open new ones 1 big change at a time. overwhelmed myself with this many changes at once. Plan to remove bitshifting again if it isnt already, 9 ball table coloring, and fix the spinning cue ball bug if it exists in master still as the first one

Legoman99573 commented 2 years ago

Plan to remove bitshifting again if it isnt already

Removed in #141