Winner is the opposite player even if no foul ball occurs

VRCBilliards / vrcbce

VRCBilliards: Community Edition

MIT License

307 stars 37 forks source link

Winner is the opposite player even if no foul ball occurs #145

Closed Legoman99573 closed 2 years ago

Legoman99573 commented 2 years ago

Not sure how this slipped during the rewrite of the pocketing functionality for 8ball. Thought I would throw it out there. Using https://github.com/VRCBilliards/vrcbce/commit/a13907b8b4a9cc65eced1c9e6241e4e6ca4befd2 atm.

FairlySadPanda commented 2 years ago

Bad timing as I am currently on holiday. Need a more specific bug report than the title so I can drill down and fix it when I am able to do VRC work again on Friday.

FairlySadPanda commented 2 years ago

Fix should be in on master, good spot

https://github.com/VRCBilliards/vrcbce/commit/67368d8b21e59f4b53d1b01205a0ff482f277728

Legoman99573 commented 2 years ago

Late response, but it has resolved the issue. No need to keep this issue open since https://github.com/VRCBilliards/vrcbce/commit/67368d8b21e59f4b53d1b01205a0ff482f277728 resolved it.