VRCBilliards / vrcbce

VRCBilliards: Community Edition
MIT License
307 stars 37 forks source link

If you are going to take code from another repo, at least credit it in your readme. #189

Closed Toasterly closed 10 months ago

Toasterly commented 10 months ago

Metaphira recently mentioned this, I thought I would say a few words,

https://github.com/VRCBilliards/vrcbce/blob/c75aa7a945350429438b4533f411dcc1e72a61cc/Packages/com.vrcbilliards.vrcbce/Runtime/Scripts/PoolStateManager.cs#L363

https://github.com/pool-parlor/pool-parlor-table/blob/415149cd8f0cc20b3579cb427301478b05c81639/Assets/metaphira/Modules/BilliardsModule/UdonScripts/StandardPhysicsManager.cs#L1304

If you are going to rip the Pool Parlor's public physics code down to even the comments you could at least credit Metaphira & the Pool Parlor for supplying the code. This makes me glad I never pushed the updated spin transfer, throw & jump physics to Github. I am honestly disappointed to see this out of VRCBCE. Recently I announced I would be deleting the Github table, this only cements that further.