search

VRCBilliards / vrcbce

VRCBilliards: Community Edition
MIT License
307 stars 37 forks source link

Table Emission Color Broken/Not Working #85

Closed BluWizard10 closed 3 years ago

BluWizard10 commented 3 years ago

Using 1.3.0. For some reason, the emission color doesn't ever update on the Table when a person's turn is changed (doesn't change to Orange). I've tried deleting the prefab and reinstalling it completely, and still doesn't work.

esnya commented 3 years ago

Looks like we've got this issue again?

BluWizard10 commented 3 years ago

Looks like we've got this issue again?

Probably? I manually set the Emission to Realtime and yet, the colors still don't change at all. I feel the scripts itself are failing to change the Material's Emission somehow.

Metamaniac commented 3 years ago

@esnya It actually doesn't matter what the emission's GI is set to, all that setting does is control how the emission value with Unity Standard is handled with Unity's GI systems (whether it gets baked, or gets applied with Realtime GI if people are using that). Unity 2019 actually lets us disable emission touching GI at all, which is what I've done as of commit https://github.com/FairlySadPanda/vrcbce/commit/e510cfc480cfc3a5b8f06ab948c6886fecf68282

This issue ended up being a scripting issue. For whatever reason the logic that actually changes the emission color at the end of the day was both commented out and written poorly, the latter likely explaining the former. Not sure when, how, or why it was like that, but I fixed it :) https://github.com/FairlySadPanda/vrcbce/commit/98619d4d9bb0cc8e2e029cedecaf2a39d2bc92f0