VRCWizard / TTS-Voice-Wizard

Speech to Text to Speech. Song now playing. Sends text as OSC messages to VRChat to display on avatar. (STTTS) (Speech to TTS) (VRC STT System) (VTuber TTS)
https://TTSVoiceWizard.com
MIT License
579 stars 66 forks source link

[BUG] STT (whisper) #43

Closed chrisk414 closed 1 year ago

chrisk414 commented 1 year ago

Hi, there! Using STT (whisper), I found a couple of bugs. (I'm running the app on Visual Studio 2022 Debug)

  1. Click on "Speech to Text to Speech" on/off several times will cause the Exception Error. image

  2. Closing the app (pressing "" icon) with "Speech to Text to Speech" Enabled, will not kill the app. There are dangling thread remaining preventing the app to exit. You will see this behavior when the app is launched from Visual Studio Debug.

I think that's all for now and many thanks for the wonderful app.

VRCWizard commented 1 year ago
  1. I've applied a possible fix, I couldn't get the error to display for myself after a couple tries although it could still be there. (I modified the ComLight.dll where the exception originates)

  2. Fixed, recognizers are now stopped on form closing

https://github.com/VRCWizard/TTS-Voice-Wizard/releases/tag/v1.4.9

chrisk414 commented 1 year ago

You are really wonderful. I'm so happy that I got to know this app and I'll try to help as much as I can to make this app better. I think the possibility of this app is limitless. I'm pretty sure you are thinking the same. ^^

chrisk414 commented 1 year ago

Hi, here is the update.

1. Still seems to be the issue. Just to let you know. ^^

2. has been fixed. Great!

Cheers!

VRCWizard commented 1 year ago
  1. Whisper can now NOT be stopped while it is launching to help avoid the AccessViolationException. If you can still reproduce the issue let me know the scenario. https://github.com/VRCWizard/TTS-Voice-Wizard/releases/tag/v1.5.1
chrisk414 commented 1 year ago

Sure, I'll.

Oh, there is compilation error at image

missing, comboBoxProBranch. ^^

VRCWizard commented 1 year ago

https://github.com/VRCWizard/TTS-Voice-Wizard/releases/tag/v1.5.1.7

chrisk414 commented 1 year ago

Thanks. It compiles. 👍

VRCWizard commented 1 year ago

Although it is still possible to cause error 1. to happen the likelihood has been drastically reduced by preventing users from stopping Whisper during it's startup so I'll be closing this issue.