Closed 532910 closed 6 years ago
Please create a pull request to propose and collaborate on changes to a repository. To find how to do it, please see the following: Creating a pull request
It's just a feature request, I don't have real changes.
Currently there are no plans to implement this feature. When we don't have an opportunity to implement a feature, we encourage developers to fork the project and become a contributor. It would be great to add another contributor to this project.
Please reopen this bug until it is not fixed!
@c-e-p-x-u-o Are you planning to implement this feature and submit a pull request?
Yep!
@VREMSoftwareDevelopment: Provide svg source please.
Android "svg" file is available in the repository ic_app_green_800_48dp.xml.
Here are a few links that maybe helpful:
Can I help in making the app icon an adaptive icon? I am a graphic designer and I want to contribute to these great project.
I can make a proposal for a new app icon design also if it's an option.
@VREMSoftwareDevelopment why have you deleted a comment from amirdesaingrafis?
$ wget https://raw.githubusercontent.com/VREMSoftwareDevelopment/WiFiAnalyzer/feature/app/src/main/res/drawable/ic_app_green_800_48dp.xml -O ic_app_green_800_48dp.svg
$ inkscape ic_app_green_800_48dp.svg
Failed to load the requested file ic_app_green_800_48dp.svg
@Tobaloidee you should not ask permission to help. Just make the icon!
@c-e-p-x-u-o okay I will post it here asap. thanks!
@Tobaloidee Please create a pull request to propose and collaborate on changes to a repository. To find how to do it, please see the following: Creating a pull request
@c-e-p-x-u-o As mentioned in previous comment, the file ic_app_green_800_48dp.xml is in "Android svg" format. Android applications require and use this format.
Please take a look at explanations provided in the following links:
Please convert "android svg" file into true svg formatted file in order to use it in Inkscape.
Hi Sir @VREMSoftwareDevelopment @c-e-p-x-u-o I want to show you my design here for I haven't done any pull request and i might screw it up so here is my design.
app icon
logotype
Adaptive icon mock-up appearances
If you have any suggestions or changes please inform me and i will edit. I hope you like it..here is the link to my drive for the editable files https://drive.google.com/drive/u/0/folders/1wmNronJbubFTUvEmX84hdvzPatHX5aYQ
Thanks a lot and best regards, -Tobaloidee
Wow! This looks really great, @Tobaloidee!
My (unsolicited) feedback is that the shadow on the right side is a bit too much. I think a simple drop shadow around the white elements would look better to my eye.
I will edit and update my post Sir! I am so glad that you liked it..I will show here first after I edit and when its good i will make the adaptive icon mockups.
Nice! I like it too.
Hi Sir @yanokwa , here it is! :)
Thanks also Sir @c-e-p-x-u-o glad that you liked it!
I talked to @lognaturel and she said that your first icon is more standard on Android these days and that I'm just old-fashioned 😂
I think @ @VREMSoftwareDevelopment should decide, but I think we should go with your first one!
I'm just here to help Sir! :+1: My first lay-out is the trend but of course whichever fits and best for the app we will go for it!
@Tobaloidee
First image looks good.
Is there are anyway to preserve wi-fi icon as green (not background)? We were trying to convey the message of good quality wi-fi connection by choosing green color.
Will new icon comply to GPLv3 copyright license? The application is licensed under GPLv3. Current icon is material design icon and is licensed under Apache License 2.0. The new/proposed icon is licensed under a Creative Commons Attribution 4.0 International License.
Thank you,
VREM Development Team
hi Sir @VREMSoftwareDevelopment
I made a version based from the original color sir.
All I want is to give this design of mine to Wifi Analyzer Sir. for free you can use it in whatever/however you want it. I updated my google drive with this new version Sir.
Please tell me sir which is the best way in turning/giving this design over to the project.
The second one: white on green without shadow.
Hi @Tobaloidee
Out of the three choices available, your first logo/icon was picked by the team. Please create a pull request with the first logo/icon.
Thank you,
VREM Development Team
Hi @VREMSoftwareDevelopment
Thanks so much for accepting my icon/design proposal for WiFI Analyzer. I just updated the readme file with the new logo thru pull request. I did not edit any codes because I'm not good with it ( I really don't know) :) If you still need any help just notice me. With that I am gladly sending you all the needed files which you can download on the link below.
https://drive.google.com/drive/u/0/folders/1wmNronJbubFTUvEmX84hdvzPatHX5aYQ
Again, best regards! -Tobaloidee
@c-e-p-x-u-o work by @Tobaloidee is merge into feature branch. Please find all required icon files in the images or images\svg folders.
(:
new/updated icons (including adaptive and legacy icons) will be available in the next release.
Please add support for icon shape https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive.html https://material.io/guidelines/style/icons.html