VREMSoftwareDevelopment / WiFiAnalyzer

Android application to analyze WiFi signals.
https://vremsoftwaredevelopment.github.io/WiFiAnalyzer/
GNU General Public License v3.0
3.24k stars 606 forks source link

Adds Latitude Longitude in Exports - Issue 152 #286

Closed mores closed 4 years ago

mores commented 4 years ago

What does this implement/fix? Please describe. Export now contains latitude and longitude.

Does this close any currently open issues? No. Issue 152 has already been closed as wontfix

Where has this been tested?

codecov[bot] commented 4 years ago

Codecov Report

Merging #286 into feature will decrease coverage by 0.31%. The diff coverage is 60%.

@@              Coverage Diff              @@
##             feature     #286      +/-   ##
=============================================
- Coverage      91.78%   91.47%   -0.32%     
+ Complexity      1052     1051       -1     
=============================================
  Files            141      141              
  Lines           3226     3237      +11     
  Branches         211      212       +1     
=============================================
  Hits            2961     2961              
- Misses           171      182      +11     
  Partials          94       94
VREMSoftwareDevelopment commented 4 years ago

@mores Thank you for pull request.

Hera are a few questions:

mores commented 4 years ago
  • Location information is only use in Export, but application is asking it in Main Activity every second. Some how it does not make sense. Is there a better way of doing it?

GPS location is not instantaneous. Main is caching the latest location, then export is occurring instantaneously. Not sure if there is a better way.

  • How pulling GPS from the phone every second effects the battery life? It is know that it is expensive battery operation.

True, the quicker the updates, the quicker the battery will drain. Perhaps a user setting could be added to indicate how often to refresh GPS location.

mores commented 4 years ago

What I would really like to see as a feature:

  1. Turn record on
  2. As you walk around signal strength and location are recorded.
  3. Turn record off
  4. Export that entire data set so a png image can be created to show coverage.
VREMSoftwareDevelopment commented 4 years ago

All these new features sounds great. Will be waiting for the new PR.