Closed mores closed 4 years ago
Merging #286 into feature will decrease coverage by
0.31%
. The diff coverage is60%
.
@@ Coverage Diff @@
## feature #286 +/- ##
=============================================
- Coverage 91.78% 91.47% -0.32%
+ Complexity 1052 1051 -1
=============================================
Files 141 141
Lines 3226 3237 +11
Branches 211 212 +1
=============================================
Hits 2961 2961
- Misses 171 182 +11
Partials 94 94
@mores Thank you for pull request.
Hera are a few questions:
- Location information is only use in Export, but application is asking it in Main Activity every second. Some how it does not make sense. Is there a better way of doing it?
GPS location is not instantaneous. Main is caching the latest location, then export is occurring instantaneously. Not sure if there is a better way.
- How pulling GPS from the phone every second effects the battery life? It is know that it is expensive battery operation.
True, the quicker the updates, the quicker the battery will drain. Perhaps a user setting could be added to indicate how often to refresh GPS location.
- Have you considered Wi-Fi location: ranging with RTT? Will this be a better solution? That may be a better solution, I will have to investigate that.
What I would really like to see as a feature:
All these new features sounds great. Will be waiting for the new PR.
What does this implement/fix? Please describe. Export now contains latitude and longitude.
Does this close any currently open issues? No. Issue 152 has already been closed as wontfix
Where has this been tested?