search

VREMSoftwareDevelopment / WiFiAnalyzer

Android application to analyze WiFi signals.
https://vremsoftwaredevelopment.github.io/WiFiAnalyzer/
GNU General Public License v3.0
3.24k stars 606 forks source link

WPA2 incorrectly displayed as WPA3 #318

Closed Jon8RFC closed 3 years ago

Jon8RFC commented 3 years ago

Describe the bug v3.0.2 displays access points as having WPA3 when they don't.

The string "RSN" is associated with WPA3 but it should be "SAE" as SAE replaced PSK in WPA3. Currently, when it sees RSN-* (which is not necessarily WPA3, but could be), it tags it as WPA3. RSN is used with both WPA2 and WPA3, but SAE is used only with WPA3.

Screenshots wpa3_bug

Additional context This doesn't account for WPA3 Enterprise, but the app currently doesn't account for WPA/WPA2 Enterprise (yet), either. I looked at making a pull request (not a software developer), but got very confused with certain parts and don't know if I can just swap every instance of RSN for SAE.

Provide Device/Android OS information Pixel 5 Android 11 RD1A.201105.003.C1

VREMSoftwareDevelopment commented 3 years ago

@Jon8RFC replacing all RSN with SAE should work. Clicking on access point in the access point list or graphs will open an popup window with more details? Can you please create a couple of screenshots with popup window information for WPA2 and WPA3? (Version 3.0.2 only) Thanks

Jon8RFC commented 3 years ago

I added one in at the bottom with 802.11r Fast Transition enabled, which I don't think I've seen other apps display in a concise manner, like how 3.0.2 cleanly shows just "WPA2", for example.

screenshots

VREMSoftwareDevelopment commented 3 years ago

will be available in next release.

Jon8RFC commented 3 years ago

I don't understand it all, but is FT being included as an identifier of WPA3? Just wanted to be sure--it's an independent protocol for roaming between different access points and is not necessarily related to a particular method of authentication or encryption.

I just thought it'd be handy to have an additional indicator, such as [FT] or [802.11r] to go alongside [WPA2], for example, since no other apps show things cleanly like yours does.

VREMSoftwareDevelopment commented 3 years ago

Android API scan capabilities information is used only identify security WPS, WPA, WPA2 and WPA3(SAE). Wi-Fi protocol standard is part on Android 11 API only. Reference: ScanResult If you wish to help and need FT/802.11r, please create pull request for this new feature.