VREMSoftwareDevelopment / WiFiAnalyzer

Android application to analyze WiFi signals.
https://vremsoftwaredevelopment.github.io/WiFiAnalyzer/
GNU General Public License v3.0
2.96k stars 578 forks source link

Implement GPS location, and bearing acquisition and export. #353

Closed skinkie closed 5 months ago

skinkie commented 3 years ago

Three years and 10 days after the suggestion https://github.com/VREMSoftwareDevelopment/WiFiAnalyzer/issues/152#issuecomment-406803520 and being inspired by @mores, a fix for #152

What does this implement/fix? Please describe. Export longitude,latitude,accuracy,bearing,bearingaccuracy along with the WiFiDetails.

Does this close any currently open issues?

152

Additional context This feature would be really useful if the app would support continuous exports, or write something to a file.

I am really a novice programmer in the Kotlin language. It might be worthwhile to move the location activity to the MainContext, to make the variable private (again).

Where has this been tested?

skinkie commented 2 years ago

@VREMSoftwareDevelopment any reason to close this issue without any feedback?

VREMSoftwareDevelopment commented 2 years ago

@skinkie there were not response to the PR feedback provided by us for over 1/2 year. Which stand to show that there no interest fixing the issues in the PR. It is always possible to re-open existing PR or submit a new PR with new code changes.

skinkie commented 2 years ago

A non-project member is not able to open a closed pull request. So yes, an open source product could be forked, but still it does not make sense when a feature is provided no reply at all is provided. With respect to 'interest' as referenced, end-users have expressed interest, including myself.

VREMSoftwareDevelopment commented 2 years ago

We have re-opened the PR, please response to our feedback(s).

VREMSoftwareDevelopment commented 2 years ago

Please make sure that this PR solves concerns raised in PR #286, since they are related.

Thanks

skinkie commented 2 years ago

Thanks. Very strange I have not received a notification about this. I'll see if I can make it work with the provided feedback.

VREMSoftwareDevelopment commented 2 years ago

Here a few links to reference documentation that may help: Optimize location for battery Background Location Limits