search

VREMSoftwareDevelopment / WiFiAnalyzer

Android application to analyze WiFi signals.
https://vremsoftwaredevelopment.github.io/WiFiAnalyzer/
GNU General Public License v3.0
2.73k stars 570 forks source link

Fix#392 #407

Closed kurahaupo closed 4 months ago

kurahaupo commented 1 year ago

What does this implement/fix? Please describe. Display the "uptime" in beacons in better human-readable format.

Does this close any currently open issues?

392

kurahaupo commented 1 year ago

fixes #392

kurahaupo commented 1 year ago

Oh dear, I've just realised this has been sending email for every pushed commit, and triggering the unit tests. Sorry about that.

I'm puzzled as to why JaCoCo now fails, when (as far as I know) I've added test coverage for all of my additions.

VREMSoftwareDevelopment commented 1 year ago

Please merge the latest feature branch into fix#392

VREMSoftwareDevelopment commented 1 year ago

Please take a look starting at build->coverage-4446

"Rule violated for bundle app: complexity covered ratio is 0.87, but expected minimum is 0.88"

It is not code coverage, it is new added code complexity.

kurahaupo commented 1 year ago

I made a specific point of adding tests, so this report is really confusing.

How is "added code complexity" computed?

Is there a penalty for code laid out in a tabular arrangement like "too many statements per line"?

kurahaupo commented 1 year ago

I wonder if the coverage tool is getting confused by having two scale measures over the same variable, and thinking they need M+N tests (or even M×N) when in fact the intentional interleaved scales mean that the actual number of tests to have full coverage is significantly fewer, basically max(M,N)+1.

I don't want to wind up with code that's harder to read just to get it to pass a metric.

VREMSoftwareDevelopment commented 1 year ago

I don't want to wind up with code that's harder to read just to get it to pass a metric.