VREMSoftwareDevelopment / WiFiAnalyzer

Android application to analyze WiFi signals.
https://vremsoftwaredevelopment.github.io/WiFiAnalyzer/
GNU General Public License v3.0
2.73k stars 570 forks source link

make it more clear that SSID filter is case sensitive #442

Closed mx1up closed 6 months ago

mx1up commented 7 months ago

What does this implement/fix? Please describe.

Does this close any currently open issues? fixes #441

Additional context

Where has this been tested?

codecov[bot] commented 7 months ago

Codecov Report

Merging #442 (2a5d9fc) into feature (2f5f3ba) will not change coverage. Report is 2 commits behind head on feature. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## feature #442 +/- ## ========================================== Coverage 92.85% 92.85% Complexity 940 940 ========================================== Files 131 131 Lines 2743 2743 Branches 229 229 ========================================== Hits 2547 2547 Misses 59 59 Partials 137 137 ```
VREMSoftwareDevelopment commented 7 months ago

This would definitely require translation to other languages currently supported by the application. There is no automatic translation workflow available in this project, if you know of any automatic translation you are welcome to implement it.

The other choice could be implementation of the universal icons (no translation required), ie: gui-case-sensitive-svgrepo-com

mx1up commented 7 months ago

ok, I will just update the translation files. For the languages that I do not know, should I provide an English stub in each language file or do I leave it out so there is fall back on the language agnostic strings.xml? Or maybe I can use google translate as it is a quite short translation? (though maybe not easy for google translate to interpret correctly..)

As a translation workflow, Transifex comes to mind, which is free for open source projects. However, I don't have experience implementing it and as this project is as good as finished, the return on investment seems quite low.

VREMSoftwareDevelopment commented 7 months ago

Or maybe I can use google translate as it is a quite short translation? (though maybe not easy for google translate to interpret correctly..)

Probably Google Translate is good enough for now.

mx1up commented 6 months ago

I have added translation, based on google translate and wikipedia. I also verified that longer strings don't pose a problem.

Is it okay to rebase?

VREMSoftwareDevelopment commented 6 months ago

Since there are not conflicts, rebase is not necessary.

mx1up commented 6 months ago

Okay, so I guess I'm ready then..

VREMSoftwareDevelopment commented 6 months ago

Thank you for your contribution

mx1up commented 6 months ago

thanks for accepting 👍