VRGhost / OctoPrint-PSUControl-Meross

Adds Meross Smart Plug support to OctoPrint-PSUControl
GNU Affero General Public License v3.0
4 stars 6 forks source link

Typo in octoprint_psucontrol_settings.js ? #12

Closed kenrf closed 1 year ago

kenrf commented 1 year ago

I believe theres a typo in octoprint_psucontrol_settings.js, line 119: if (!username || !password || !device_id) { should actually be if (!username || !password || !device_ids) {

Have been having issues testing the toggle feature in the plugin settings page (it just doesn't work) and I think this is my issue. Not setup to debug or dev octoprint plugins so figured i'd create an issue to be checked.

VRGhost commented 1 year ago

Oh, right.

Yes, I've just added multiple device IDs support the other week, forgot to check the JS. Thank you.

VRGhost commented 1 year ago

Fixed in 0.13.1.

Thank you for reporting this.