search

VROOM-Project / pyvroom

Vehicle Routing Open-source Optimization Machine
BSD 2-Clause "Simplified" License
69 stars 14 forks source link

try python version 3.12 #102

Closed jonathf closed 9 months ago

jonathf commented 9 months ago

Solves #101.

nilsnolde commented 9 months ago

FWIW, the doctest failure makes sense, we recently added different data to Valhalla which makes the durations quite a bit longer.

jonathf commented 9 months ago

Yeah, I doubted that had anything to do with this patch. I am rerunning the a new tag on current main to see if the Windows failure are connected.

Nils, you added the 3.12 restriction. Do you remember why, and if we can expect it to resolve it self now that 3.12 is out stable?

nilsnolde commented 9 months ago

Yeah I’m pretty sure that was only because it wasn’t release yet, but it was built by default. In fact I think 3.12 introduced ABI stability in between minor versions, so in uhh, 5 years from now (?) we can stop building all of them;)

jonathf commented 9 months ago

@jcoupey, we have a small issue.

PyPI which hosts all python packages have started to require deploy tokens for publishing. I don't seem to have the rights to add Github secrets to so we can use it with Github actions.

We have a few options I think:

  1. Do you (or @nilsnolde ) want access to pyvroom om pypi so you can fix the deploy token issue?
  2. Do you want me to create the token, and you add it?
  3. If possible can I have access to adding secrets?
jcoupey commented 9 months ago

@jonathf option 2 sounds like the easiest one here.

jonathf commented 9 months ago

Sure. How would you like the token sent over?

jcoupey commented 9 months ago

You can use the contact email on http://vroom-project.org.

jonathf commented 9 months ago

Done. The secrets variable (likely moved when pyvroom joined vroom-project) is pypi_password. Feel free to override it with the new token.

codecov[bot] commented 9 months ago

Codecov Report

Merging #102 (05fcd5b) into main (d313bbe) will not change coverage. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #102 +/- ## ===================================== Coverage 80.1% 80.1% ===================================== Files 29 29 Lines 1523 1523 Branches 17 17 ===================================== Hits 1220 1220 Misses 294 294 Partials 9 9 ``` | [Flag](https://app.codecov.io/gh/VROOM-Project/pyvroom/pull/102/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VROOM-Project) | Coverage Δ | | |---|---|---| | [binding](https://app.codecov.io/gh/VROOM-Project/pyvroom/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VROOM-Project) | `71.2% <ø> (ø)` | | | [python](https://app.codecov.io/gh/VROOM-Project/pyvroom/pull/102/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VROOM-Project) | `91.4% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=VROOM-Project#carryforward-flags-in-the-pull-request-comment) to find out more.
jcoupey commented 9 months ago

Thanks, just updated the pypi_password secret with the token you sent. Let me know if there is anything else required.

jonathf commented 9 months ago

Looks like it works as intended. Thanks for the quick assist @jcoupey!