VROOM-Project / pyvroom

Vehicle Routing Open-source Optimization Machine
BSD 2-Clause "Simplified" License
67 stars 14 forks source link

Enable windows support again #56

Closed jonathf closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #56 (b15f685) into main (66f547b) will increase coverage by 1.3%. The diff coverage is n/a.

@@           Coverage Diff           @@
##            main     #56     +/-   ##
=======================================
+ Coverage   80.1%   81.4%   +1.3%     
=======================================
  Files         28      28             
  Lines       1315    1321      +6     
  Branches      17      17             
=======================================
+ Hits        1054    1076     +22     
+ Misses       252     235     -17     
- Partials       9      10      +1     
Flag Coverage Δ
binding 72.8% <ø> (+2.5%) :arrow_up:
python 91.4% <ø> (-0.3%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

nilsnolde commented 2 years ago

this worked. I canceled the release actions. I wonder why they even started, I didn't publish any tag.. github being buggy again?

anyways, what do you think @jonathf ? should we look at merging the vroom PR to your repo before merging this so we can change the submodule again?

nilsnolde commented 2 years ago

I wonder why they even started

added a branches-ignore: '*', seems to work.

jonathf commented 2 years ago

No, sorry. I made the tag. I didn't see you triggering actions manually. I'm looking at th code now.

nilsnolde commented 2 years ago

ha weird, never noticed that I don't get notified via email when someone tags.

github's documentation is really fuzzy about it. I thought maybe it's also triggering on all branches by default. we can still leave it in for clarity I guess.

no stress reviewing, but thanks:)

jonathf commented 2 years ago

This is awesome. Thanks for doing this.