VROOM-Project / pyvroom

Vehicle Routing Open-source Optimization Machine
BSD 2-Clause "Simplified" License
69 stars 14 forks source link

add USE_ROUTING compiler arg #76

Closed nilsnolde closed 1 year ago

nilsnolde commented 1 year ago

fixes #60

Should build the lib with USE_ROUTING=true. No test, little time at the moment. Eventually IMO we should add some (HTTP) integration test with at least one router.

codecov[bot] commented 1 year ago

Codecov Report

Merging #76 (4f6e7d0) into main (500e991) will decrease coverage by 1.1%. The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main     #76     +/-   ##
=======================================
- Coverage   79.4%   78.3%   -1.1%     
=======================================
  Files         29      29             
  Lines       1491    1516     +25     
  Branches      14      17      +3     
=======================================
+ Hits        1184    1188      +4     
- Misses       298     319     +21     
  Partials       9       9             
Flag Coverage Δ
binding 68.1% <100.0%> (-1.6%) :arrow_down:
python 91.5% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jonathf commented 1 year ago

Thank you @nilsnolde and @juanluisrto for the patches

jcGourcuff commented 1 year ago

Hi, I ran into the same issue that led to this PR - I am able to build from source on my machine with the latest changes and it works fine. However I have to set it up on other machines that work on various OS and the build process becomes quite tedious. As this patch is quite critical, would it make sens to release a new PyPi version of the package so we could just pip install it ? Thanks !

jonathf commented 1 year ago

New release came out Yesterday: version 1.13.2.

jcGourcuff commented 1 year ago

My bad - thank you !