Closed nilsnolde closed 1 year ago
Can't see how that wouldn't work, but we won't know before we merge to master. I'd take the risk personally, but if you want I can also try cibuildwheel
locally, I'm pretty sure I did that before on linux. What's your take @jonathf ?
Merging #96 (56856ec) into main (c140205) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## main #96 +/- ##
=====================================
Coverage 80.1% 80.1%
=====================================
Files 29 29
Lines 1523 1523
Branches 17 17
=====================================
Hits 1220 1220
Misses 294 294
Partials 9 9
Flag | Coverage Δ | |
---|---|---|
binding | 71.2% <ø> (ø) |
|
python | 91.4% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
To build without release, use the -dev
tag suffix. I just pushed the tag 1.13.3-dev5
to demonstrate.
When it builds and deploys properly, you can install it from pypi using the specific tag. E.g. pip install pyvroom==1.13.3.dev5
. (Note the change in syntax.)
Was failing a bit, good idea with -devx release. I'll let you know after it built properly.
this is good to merge, tested the README examples locally with 1.13.3-dev6
Here the action for the dev release: https://github.com/VROOM-Project/pyvroom/actions/runs/5927050551
1.13.3-dev6
passes the test on my machine as well. Good work, Nils!
fixes #93
I also upgraded the Github Actions to their latest releases.