Closed nilsnolde closed 2 years ago
currently we only test for a vroom-express failure it seems, meaning vroom is never actually called and issues like #61 can go unnoticed.
we definitely need to make that more robust and test for a 200 as well with the example2.json.
in fact, I just see that we actually do want to request for a 200, but curl doesn't fail unless called with --fail: https://github.com/VROOM-Project/vroom-docker/blob/df2a6202df8c3ac41f27a6187c81d6db8d6e6364/tests/test.sh#L31-L32
curl
--fail
easy fix, I'll that real quick.
currently we only test for a vroom-express failure it seems, meaning vroom is never actually called and issues like #61 can go unnoticed.
we definitely need to make that more robust and test for a 200 as well with the example2.json.
in fact, I just see that we actually do want to request for a 200, but
curldoesn't fail unless called with--fail: https://github.com/VROOM-Project/vroom-docker/blob/df2a6202df8c3ac41f27a6187c81d6db8d6e6364/tests/test.sh#L31-L32easy fix, I'll that real quick.