search

VROOM-Project / vroom-docker

Docker image for vroom and vroom-express
BSD 2-Clause "Simplified" License
88 stars 58 forks source link

Update checkout action #85

Open kkarbowiak opened 2 months ago

jcoupey commented 2 months ago

We're still running into the same problem as #84: looks like ubuntu-latest as spelled out in the workflows still trigger 20.04.

kkarbowiak commented 2 months ago

We're still running into the same problem as #84: looks like ubuntu-latest as spelled out in the workflows still trigger 20.04.

The ubuntu-latest should point to 22.04, but this is just the OS used by the GitHub Runner. The code is built inside a Docker container as configured in the Dockerfile: https://github.com/VROOM-Project/vroom-docker/blob/c24f900b2f4886ae12411ebd20670684ca2e5d23/Dockerfile#L1

Changing this to FROM ubuntu:24.04 as builder makes the code compile, but a subsequent step fails.

jcoupey commented 2 months ago

My bad, I was indeed messing things between the runner and the actual image…

Bookworm has gcc 12 which does not support format. We want gcc 13 or 14 as used in the upstream CI runs.