VRPirates / rookie

GNU General Public License v3.0
346 stars 27 forks source link

Copying the complete list to the clipboard (using CTRL+L/ALT+L) doesn't copy every name #110

Closed OldWarez closed 3 months ago

OldWarez commented 6 months ago

The ones I've noticed are Game Names:

Myst Pong Pool

...they end up being totally absent in either listing method.

frxctura commented 5 months ago

I'm unable to reproduce this on 2.29.2, the gamelist properly copies Myst, is an actual game name within the list, so is Pong, and so is Pool.

OldWarez commented 5 months ago

This still acts this way here, Win 10:

Fresh install of 2.92.2 Nothing selected in file list Cursor in one of the fields above the file list so that hitting a keyboard key doesn't jump to that letter. CTRL+L or ALT+L Paste into Notepad Resulting list doesn't have the games mentioned, while they exist in the program's selector

If I highlight one of the mentioned games, move the cursor to another field as above, and copy the package name, -that- copies fine

--

[EDIT: More games that don't end up in the copied list:

Football
Triton

--

[EDIT 2: So I haven't messed with this language but, I'm guessing that the 'contains' in the following is the problem...

(Multiple times in MainForm.cs:)

                            if (!rookienamelist.Contains(release[SideloaderRCLONE.GameNameIndex].ToString()))
                            {
                                rookienamelist += release[SideloaderRCLONE.GameNameIndex].ToString() + "\n";
                                rookienamelist2 += release[SideloaderRCLONE.GameNameIndex].ToString() + ", ";
                            }

...to me, that wouldn't add something to the running list when it finds a game's name that has it as a substring in an EARLIER game in the list, right?

Football has 2MD- VR Football Unleashed ALLSTAR before it Myst has a ton of games before it with Myst* in the name Pong has Ping Pong before it Pool has lots of uses of Pool before it Triton has FREEDIVER- Triton Down before it

...and if it wasn't case-sensitive, I'd figure that one of the 'Chess/chess' entries, and STACK would be gone from the clipboard list.

frxctura commented 4 months ago

I've committed a change at fix/CopyGameList, instead of building a list when loading it, we now copy the items directly, if you're able to build, give it an attempt and see if this solution works for you, from my testing it seems to have included all items properly now.