vrp-public.json is only updated when the file already exists

VRPirates / rookie

GNU General Public License v3.0

346 stars 27 forks source link

vrp-public.json is only updated when the file already exists #73

Closed DanTheMan827 closed 10 months ago

DanTheMan827 commented 10 months ago

Probably also the cause of #69 and similar issues.

Manually downloading https://vrpirates.wiki/downloads/vrp-public.json to the program directory fixed the issue shown.

If you look at line 212 of MainForm.cs, there's a check enclosing the portion of the code responsible.

https://github.com/VRPirates/rookie/blob/0bf9a00af2c0f88745afb349c4c0200a400bb1fd/MainForm.cs#L212

I don't think this should be there?

The same is also true for the PCVR version and vrp-public-pcvr.json

frxctura commented 10 months ago

Works as intended, you wouldn't have the problem if youre downloading from our wiki as we package our releases with those files.

You're not supposed to DL off our GitHub really, the binaries here are meant for reference and for updating Rookie from in-app.

Fenopy commented 10 months ago

As @Chax1 said, this is not an application issue. Rookie is designed to work with many configurations and automatically overriding/downloading a configuration file is not how it is intended to act.