suggestions: typed code, design by contract

VRSEN / agency-swarm

The only reliable agent framework built on top of the latest OpenAI Assistants API.

https://vrsen.github.io/agency-swarm/

MIT License

2.05k stars 537 forks source link

Closed Morriz closed 1 month ago

Morriz commented 2 months ago

Hi, I think this code base is not following best practices and could use the following:

typing: I'd say research the benefits if you care
design by contract: same, I suggest to investigate. It offers clear separation of concerns, and does away with useless input checking

VRSEN commented 2 months ago

Please specify the lines of code or files where types are missing, and explain where DbC should be implemented and why.

If you continue to open issues like this, I will have to block you.