In the Agent.init_oai method, the _check_parameters method is called after the agent's attributes (such as instructions, name, description, etc.) have been updated. This results in the _check_parameters method always returning True, as it compares the updated attributes with themselves. Consequently, the assistant is never updated even when the parameters differ.
Impact
This issue prevents the assistant from being updated when its parameters change, potentially leading to outdated or incorrect assistant configurations being used.
Suggested Solution
To resolve this issue, the _check_parameters method should be called before updating the agent's attributes. This way, the method can correctly determine if the parameters have changed and update the assistant if necessary.
File:
agency_swarm/agents/agent.pyMethod:
Agent.init_oaiLine: 180
Description
In the
Agent.init_oaimethod, the_check_parametersmethod is called after the agent's attributes (such asinstructions,name,description, etc.) have been updated. This results in the_check_parametersmethod always returningTrue, as it compares the updated attributes with themselves. Consequently, the assistant is never updated even when the parameters differ.Impact
This issue prevents the assistant from being updated when its parameters change, potentially leading to outdated or incorrect assistant configurations being used.
Suggested Solution
To resolve this issue, the
_check_parametersmethod should be called before updating the agent's attributes. This way, the method can correctly determine if the parameters have changed and update the assistant if necessary.